[PATCH] D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/utils/TableGen/TableGen.cpp:138
         clEnumValN(GenDirectivesEnumGen, "gen-directive-gen",
                    "Generate directive related implementation code part")));
 
----------------
clementval wrote:
> Meinersbur wrote:
> > What does "part" refer to?
> It refers to various code "part" needed in clang and flang and libFrontend. Not sure if we can be more precise here.  
"part" seems to refer to `-gen-directive-impl`, as in "the other part of the implementation". Again, I suggest to keep the `gen-directive-impl` flag instead. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93560/new/

https://reviews.llvm.org/D93560