[PATCH] D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc

Wed Mar 17 04:33:54 PDT 2021

clementval added a comment.

In D93560#2630347 <https://reviews.llvm.org/D93560#2630347>, @Meinersbur wrote:

> I'd prefer using the name "impl" for the implementation, but my LGTM does not depend on it.

Thanks for the review.

I'm fine with changing the current name to `impl`. @kiranchandramohan What do you think about it?

================
Comment at: llvm/utils/TableGen/TableGen.cpp:138
         clEnumValN(GenDirectivesEnumGen, "gen-directive-gen",
                    "Generate directive related implementation code part")));

----------------
Meinersbur wrote:
> What does "part" refer to?
It refers to various code "part" needed in clang and flang and libFrontend. Not sure if we can be more precise here.  

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93560/new/

https://reviews.llvm.org/D93560