[PATCH] D98086: [FileCheck] Fix numeric error propagation

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

I've gone through the code and briefly skimmed the tests. I need to focus on clearing other reviews, so won't spend more time on this, and I didn't see any further problems, so LGTM.



================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:1376
   }
   for (const auto &VariableDef : NumericVariableDefs) {
     VarCapture VC;
----------------
jdenny wrote:
> jhenderson wrote:
> > Aside: this is a good example of where `auto` is hurting readability of the code. I can't tell whether `VariableDef` is an `Optional`, or something else with a `getValue()` method below. If it's the former, you could replace `getValue()` with `->` for example.
> Perhaps we need a patch that adjusts all such occurrences in this file.
+1 to that suggestion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98086/new/

https://reviews.llvm.org/D98086