[PATCH] D98673: [llvm-reduce] Remove dso_local when possible

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 12:20:43 PDT 2021


aeubanks added a comment.

The only way to remove dso_local is via `GlobalValue::setDSOLocal()`, I don't think there is some more generic way to do it.

When reducing, we should decide if we want to reduce to dso_local or the default (dso_preemptable), but we shouldn't just leave it be. Either way is fine to me, although I slightly prefer removing it since it makes the printed IR cleaner, even if that's technically less strict.

> We also miss nuw/nsw/inbounds/exact and likely others.

We should also do these, but in a future patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98673/new/

https://reviews.llvm.org/D98673



More information about the llvm-commits mailing list