[PATCH] D98673: [llvm-reduce] Remove dso_local when possible

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D98673#2628677 <https://reviews.llvm.org/D98673#2628677>, @fhahn wrote:

> In D98673#2628149 <https://reviews.llvm.org/D98673#2628149>, @lebedev.ri wrote:
>
>> We are indeed missing reductions of a number of such things, but isn't this a bit too specialized?
>> I don't know what the solution is (and that is why i didn't touch it), but i'd be hoping for something more generic..
>
> We should probably also try to reduce the linkage & visibility. Although it is not  completely clear what 'reduced'/'simpler' means here. But I guess it might make sense to try to set them to the default values? Is this the direction you meant with 'more generic' or reducing other bits of globals as well?

When I'm reducing codegen problems, I tend to make the linkage and visibility stricter since it ends up with fewer machine instructions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98673/new/

https://reviews.llvm.org/D98673