[PATCH] D98695: [Docs] Suggest mentioning review page in the commit message

Vaivaswatha Nagaraj via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 05:12:06 PDT 2021


vaivaswatha added a comment.

In D98695#2628657 <https://reviews.llvm.org/D98695#2628657>, @rengolin wrote:

> Actually, this is mentioned in a different document: https://www.llvm.org/docs/Phabricator.html#committing-a-change
>
> I agree this isn't perfect and I think your change is worth doing. Can you also add a link to the URL above?
>
> Something like "add a link to its review page, as shown in [Phab link]".
>
> Thanks!

Thank you @rengolin . I've added this link now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98695/new/

https://reviews.llvm.org/D98695



More information about the llvm-commits mailing list