[PATCH] D98695: [Docs] Suggest mentioning review page in the commit message
Vaivaswatha Nagaraj via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 16 05:11:35 PDT 2021
vaivaswatha updated this revision to Diff 330949.
vaivaswatha added a comment.
Add missing fullstop.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98695/new/
https://reviews.llvm.org/D98695
Files:
llvm/docs/DeveloperPolicy.rst
Index: llvm/docs/DeveloperPolicy.rst
===================================================================
--- llvm/docs/DeveloperPolicy.rst
+++ llvm/docs/DeveloperPolicy.rst
@@ -291,6 +291,9 @@
related commit. This could be as simple as "Revert commit NNNN because it
caused PR#".
+* If the patch has been reviewed, add a link to its review page, as shown
+ `here <https://www.llvm.org/docs/Phabricator.html#committing-a-change>`_.
+
For minor violations of these recommendations, the community normally favors
reminding the contributor of this policy over reverting. Minor corrections and
omissions can be handled by sending a reply to the commits mailing list.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98695.330949.patch
Type: text/x-patch
Size: 674 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210316/fa3eafb9/attachment.bin>
More information about the llvm-commits
mailing list