[PATCH] D98620: [NFC] [XCOFF] Update PowerPC readobj test case with expression for Index and ContainingCsectSymbolIndex

Edwin Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 16 01:37:47 PDT 2021


edwin added a comment.

In D98620#2625440 <https://reviews.llvm.org/D98620#2625440>, @jhenderson wrote:

> What's the motivation for/benefit of doing this?

Thank you for your comments. I updated the summary.

To address @hubert.reinterpretcast's comment in D97117 <https://reviews.llvm.org/D97117>, this patch leverage expression to replace the fixed value in `Index` and `ContainingCsectSymbolIndex` for `Symbol`s.
Keep `.file` section as fixed values as it might be changed by coming patches. The remaining sections will hardly be modified. So the `Index` values are sequential. By using expression, we can avoid the fixed value changes effort.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98620/new/

https://reviews.llvm.org/D98620



More information about the llvm-commits mailing list