[PATCH] D98620: [NFC] [XCOFF] Update PowerPC readobj test case with expression for Index and ContainingCsectSymbolIndex

[Edwin Wang via Phabricator via llvm-commits]

edwin added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll:213
 ; SYMS-NEXT:   Symbol {
-; SYMS-NEXT:     Index: 0
+; SYMS-NEXT:     Index: [[#INDX:]]
 ; SYMS-NEXT:     Name: .file
----------------
shchenz wrote:
> This seems not right as for now symbol 0 is always for `.file`, we don't need to make this one as the base, otherwise there is no meaning at all for this change.  Now with this change, when we add some aux entry for `.file` symbol, we need to update all the following symbol entries. Without the change, with the `.text` symbol base, we don't need to do any change to existing symbols.
Addressed in new patch. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98620/new/

https://reviews.llvm.org/D98620