[PATCH] D90831: DebugInfo support for OCaml bindings

[Vaivaswatha Nagaraj via Phabricator via llvm-commits]

vaivaswatha updated this revision to Diff 330889.
vaivaswatha added a comment.

Fix clang-tidy warning on header guard  name convention.

With this, there are now the following clang-tidy issues still reported:

1. `error: 'caml/memory.h' file not found`. This has been around already for `llvm_ocaml.c` (and now we see it for the new file `llvm_debuginfo.c`).
2. `warning: invalid case style for variable 'value'` and similar warnings for the variable and function name casing convention used. I'm choosing to ignore this because the convention I've used is on par with what was already used in the LLVM OCaml interface.
3. `warning: invalid case style for variable 'i': for (int i = 0; i < NumEntries; i++) {`. This is a bit grey because both conventions are used in the file already. So I've stuck to using the smaller case as similar loops (when integers are iterated with) have this convention.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90831/new/

https://reviews.llvm.org/D90831

Files:
  llvm/bindings/ocaml/.ocamlformat
  llvm/bindings/ocaml/CMakeLists.txt
  llvm/bindings/ocaml/README.txt
  llvm/bindings/ocaml/debuginfo/CMakeLists.txt
  llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c
  llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml
  llvm/bindings/ocaml/debuginfo/llvm_debuginfo.mli
  llvm/bindings/ocaml/llvm/CMakeLists.txt
  llvm/bindings/ocaml/llvm/META.llvm.in
  llvm/bindings/ocaml/llvm/llvm.ml
  llvm/bindings/ocaml/llvm/llvm.mli
  llvm/bindings/ocaml/llvm/llvm_ocaml.c
  llvm/bindings/ocaml/llvm/llvm_ocaml.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90831.330889.patch
Type: text/x-patch
Size: 83382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210316/2aeeecba/attachment-0001.bin>