[PATCH] D90831: DebugInfo support for OCaml bindings

[Vaivaswatha Nagaraj via Phabricator via llvm-commits]

vaivaswatha updated this revision to Diff 330886.
vaivaswatha added a comment.

@jberdine: I have now updated the patch with documentation for the newly added APIs, inline. Further:

1. I removed the function `llmetadata_null`. I'm not sure where it's required except to clear the metadata in `instr_set_debug_loc`.
2. Consequent to (1), I changed the interface of `instr_set_debug_loc` to take `llmetadata option`.
3. Minor: Moved the declarations of 3 functions that you had added (which came here because I cherry-picked your commits) from the end to somewhere in between where the order of the function declarations match that of the C API.
4. I had missed including `llvm_ocaml.h` in `llvm_ocaml.c`. Fixed this now.
5. The fix to `cstr_to_string` to use `CAML*` declarations.
6. In all references to LLVM functions in the documentation, I've referred to the C-API rather than the C++ one because the C-API has a more detailed explanation of the arguments to the functions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90831/new/

https://reviews.llvm.org/D90831

Files:
  llvm/bindings/ocaml/.ocamlformat
  llvm/bindings/ocaml/CMakeLists.txt
  llvm/bindings/ocaml/README.txt
  llvm/bindings/ocaml/debuginfo/CMakeLists.txt
  llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c
  llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml
  llvm/bindings/ocaml/debuginfo/llvm_debuginfo.mli
  llvm/bindings/ocaml/llvm/CMakeLists.txt
  llvm/bindings/ocaml/llvm/META.llvm.in
  llvm/bindings/ocaml/llvm/llvm.ml
  llvm/bindings/ocaml/llvm/llvm.mli
  llvm/bindings/ocaml/llvm/llvm_ocaml.c
  llvm/bindings/ocaml/llvm/llvm_ocaml.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90831.330886.patch
Type: text/x-patch
Size: 83367 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210316/b33ee70e/attachment.bin>