[PATCH] D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 15 12:55:11 PDT 2021
clementval added a comment.
In D93560#2627056 <https://reviews.llvm.org/D93560#2627056>, @Meinersbur wrote:
> However, emitting everything into a single file and selecting using preprocessor directives doesn't seem what other tablegen targets are doing. E.g. for intrinsics there is `IntrinsicImpl.inc`, `IntrinsicEnums.inc`. Clang has `Attrs.inc`, `AttrImpl.inc`, `AttrVisitor.inc`, etc.
This is what MLIR is doing with all its TableGen related code generation. Since we are generating lots of different code block, the number of files would probably explode.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93560/new/
https://reviews.llvm.org/D93560
More information about the llvm-commits
mailing list