[PATCH] D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc
    Michael Kruse via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Mar 15 12:47:31 PDT 2021
    
    
  
Meinersbur added a comment.
Not generating a translation unit directly but including the generated part is great.
However, emitting everything into a single file and selecting using preprocessor directives doesn't seem what other tablegen targets are doing. E.g. for intrinsics there is `IntrinsicImpl.inc`, `IntrinsicEnums.inc`. Clang has `Attrs.inc`, `AttrImpl.inc`, `AttrVisitor.inc`, etc.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93560/new/
https://reviews.llvm.org/D93560
    
    
More information about the llvm-commits
mailing list