[PATCH] D98086: [FileCheck] Fix numeric error propagation

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 330758.
jdenny marked 3 inline comments as done.
jdenny added a comment.

Address @jhenderson's review.

`printMatch` and `printNoMatch` now return either `ErrorSuccess` or `ErrorReported`, which is a new class so that these functions can inform their callers that some error has occurred but has already been reported.  In most cases, I've wrapped the `printMatch` and `printNoMatch` calls in `reportMatchResult`, which cleans up the callers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98086/new/

https://reviews.llvm.org/D98086

Files:
  llvm/include/llvm/FileCheck/FileCheck.h
  llvm/lib/FileCheck/FileCheck.cpp
  llvm/lib/FileCheck/FileCheckImpl.h
  llvm/test/FileCheck/match-time-error-propagation/invalid-excluded-pattern.txt
  llvm/test/FileCheck/match-time-error-propagation/invalid-expected-pattern.txt
  llvm/test/FileCheck/match-time-error-propagation/matched-excluded-pattern.txt
  llvm/test/FileCheck/match-time-error-propagation/matched-expected-pattern.txt
  llvm/unittests/FileCheck/FileCheckTest.cpp
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98086.330758.patch
Type: text/x-patch
Size: 44089 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210315/d97ae2f6/attachment.bin>