[PATCH] D98228: [AssumeBundles] Add nonnull/align to op bundle if noundef exists

Mon Mar 15 10:18:45 PDT 2021

Tyker accepted this revision.
Tyker added a comment.

In D98228#2624345 <https://reviews.llvm.org/D98228#2624345>, @aqjune wrote:

> In D98228#2613304 <https://reviews.llvm.org/D98228#2613304>, @Tyker wrote:
>
>> I think the process of checking is a value is noundef needs to be more general than just calls. maybe addKnowledge would be a better place.
>> because nonnull and align information can also be inferred from loads/stores.
>
> Hi, sorry for my delay in response.
> Could you elaborate a bit with an example, please?
> Does it mean that the updated analysis may return suboptimal results?

after the further thinking moving nonundef checking to addKnowledge is not needed since if align or nonnnull was wrong the load/store would have UB.

the code is much shorter and much more readable now.
LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98228/new/

https://reviews.llvm.org/D98228