[PATCH] D98228: [AssumeBundles] Add nonnull/align to op bundle if noundef exists

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp:201
     addKnowledge({Attr.getKindAsEnum(), AttrArg, WasOn});
   }
 
----------------
jdoerfert wrote:
> I think this interface must take a Use not a value. Then you can check if `Attr` is allowed to be transformed into an operand bundle by checking if the use has `noundef` as well.
Checking if the use (parameter) has noundef seemed great idea to me, it could shorten the code quite a bit.
Though I put the check at addCall because it already has a CallBase object and the argument index. I'm happy to move towards making WasOn `Use &` it it can be simplified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98228/new/

https://reviews.llvm.org/D98228