[PATCH] D96628: [VPlan] Add plain text (not DOT's digraph) dumps

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Please wait a day or 2 with committing, in case there are any remaining concerns with the direction. But I think it is a nice improvement to the user experience.



================
Comment at: llvm/test/Transforms/LoopVectorize/vplan-dot-printing.ll:3
+
+; RUN: opt -loop-vectorize -debug-only=loop-vectorize -force-vector-interleave=1 -force-vector-width=4 -prefer-inloop-reductions -vplan-print-in-dot-format -disable-output %s 2>&1 | FileCheck %s
+
----------------
`-prefer-inloop-reductions ` should not be needed


================
Comment at: llvm/test/Transforms/LoopVectorize/vplan-dot-printing.ll:26
+for.body:                                         ; preds = %entry, %for.body
+  %iv = phi i64 [ %iv.next, %for.body ], [ 0, %entry ]
+  %arrayidx = getelementptr inbounds float, float* %y, i64 %iv
----------------
Nit: it would be good to at least one additional BB in the loop, to make sure the edges between blocks are still printed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96628/new/

https://reviews.llvm.org/D96628