[PATCH] D96628: [VPlan] Add plain text (not DOT's digraph) dumps

Andrei Elovikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 12 11:53:27 PST 2021


a.elovikov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:406
+  for (auto *Succ : getSuccessors())
+    O << Indent << " " << Succ->getName();
+  O << '\n';
----------------
fhahn wrote:
> I think it would be good to separate the block names by a comma or something like that. You could either use `join_items` or `ListSeparator` from `StringExtras.h`
`ListSeparator` is great! Wasn't aware of it before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96628/new/

https://reviews.llvm.org/D96628



More information about the llvm-commits mailing list