[PATCH] D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax

[Anirudh Prasad via Phabricator via llvm-commits]

anirudhp marked an inline comment as done.
anirudhp added inline comments.


================
Comment at: llvm/unittests/MC/SystemZ/CMakeLists.txt:11
+
+add_llvm_unittest(SystemZAsmLexer
+  SystemZAsmLexerTest.cpp
----------------
thakis wrote:
> thakis wrote:
> > All other unit test binaries have a name that ends in "Tests". Could this one too?
> > 
> > Actually, does this need to be in its own binary? Can't this just be part of MCTests?
> > All other unit test binaries have a name that ends in "Tests". Could this one too?
> > 
> > Actually, does this need to be in its own binary? Can't this just be part of MCTests?
> 
> I retract the second question – I guess it's due to the dep on SystemZ. First question still stands, though :)
Ahhh, this commit was just merged in :( 

How about I do this? 

I'm working on another patch, and that patch is going to need changes to this test again. At that point, I will suffix the name of the test with "Tests". Does that sound okay? (I'll make sure to add you as the reviewer! :) ) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97703/new/

https://reviews.llvm.org/D97703