[PATCH] D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/unittests/MC/SystemZ/CMakeLists.txt:11
+
+add_llvm_unittest(SystemZAsmLexer
+  SystemZAsmLexerTest.cpp
----------------
thakis wrote:
> All other unit test binaries have a name that ends in "Tests". Could this one too?
> 
> Actually, does this need to be in its own binary? Can't this just be part of MCTests?
> All other unit test binaries have a name that ends in "Tests". Could this one too?
> 
> Actually, does this need to be in its own binary? Can't this just be part of MCTests?

I retract the second question – I guess it's due to the dep on SystemZ. First question still stands, though :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97703/new/

https://reviews.llvm.org/D97703