[PATCH] D98456: [scudo][standalone] Add shared library to makefile
Kostya Kortchinsky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 11 15:57:44 PST 2021
cryptoad added inline comments.
================
Comment at: compiler-rt/lib/scudo/standalone/CMakeLists.txt:134
+
+append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread SCUDO_LINK_LIBS)
+
----------------
hctim wrote:
> Shouldn't this be `-pthread` to ldflags, not linking `lpthread`?
>
> i.e.
>
> `append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread SCUDO_LINK_FLAGS)`
Right, thanks! Not sure how it worked without the `-` either.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98456/new/
https://reviews.llvm.org/D98456
More information about the llvm-commits
mailing list