[PATCH] D98456: [scudo][standalone] Add shared library to makefile

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 11 15:19:27 PST 2021


hctim added a comment.

LGTM w/ nit



================
Comment at: compiler-rt/lib/scudo/standalone/CMakeLists.txt:134
+
+append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread SCUDO_LINK_LIBS)
+
----------------
Shouldn't this be `-pthread` to ldflags, not linking `lpthread`?

i.e.

`append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread SCUDO_LINK_FLAGS)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98456/new/

https://reviews.llvm.org/D98456



More information about the llvm-commits mailing list