[PATCH] D98374: [test-suite] SPEC2017 CPU CAM4 portability updates.

Thu Mar 11 15:22:57 PST 2021

Meinersbur added inline comments.

================
Comment at: External/SPEC/CFP2017rate/527.cam4_r/CMakeLists.txt:574
+
+check_fortran_compiler_flag("-fallow-argument-mismatch" ALLOW_MISMATCH)
+if (ALLOW_MISMATCH)
----------------
Naming convention for the feature-test variable usually starts with "SUPPORTS_" or "${lang}_SUPPORTS_", e.g. `FORTRAN_SUPPORTS_FALLOW_ARGUMENT_MISMATCH`.

================
Comment at: cmake/modules/Fortran.cmake:30-36
+
+# standard CMake Utility Modules specific to Fortran
+# https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html
+include(CheckFortranCompilerFlag)
+include(CheckFortranFunctionExists)
+include(CheckFortranSourceCompiles)
+include(CheckFortranSourceRuns)
----------------
Why add more than CheckFortranCompilerFlag?

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98374/new/

https://reviews.llvm.org/D98374