[PATCH] D98304: [AMDGPU] Create AMDGPUModuleInfo

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUModuleInfo.cpp:57
+
+  this->M = M;
+  LLVMContext &CTX = M->getContext();
----------------
arsenm wrote:
> rampitec wrote:
> > arsenm wrote:
> > > Why does this need to store a module? The context may be used by multiple modules. It shouldn't matter since this just needs the context IDs
> > It could remember context, but since it is named ModuleInfo I am keeping track of a module. Probably it can be renamed as AMDGPUContextInfo and track the context.
> It's not tracking anything about the module either. It's purely a context extension
At least not so far. I will rename it tomorrow and will track the context. It will have to stay a module pass though, but I guess it is cheap. I will just have to check context didn't change before I reset it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98304/new/

https://reviews.llvm.org/D98304