[PATCH] D98304: [AMDGPU] Create AMDGPUModuleInfo

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 16:52:42 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUModuleInfo.cpp:57
+
+  this->M = M;
+  LLVMContext &CTX = M->getContext();
----------------
rampitec wrote:
> arsenm wrote:
> > Why does this need to store a module? The context may be used by multiple modules. It shouldn't matter since this just needs the context IDs
> It could remember context, but since it is named ModuleInfo I am keeping track of a module. Probably it can be renamed as AMDGPUContextInfo and track the context.
It's not tracking anything about the module either. It's purely a context extension


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98304/new/

https://reviews.llvm.org/D98304



More information about the llvm-commits mailing list