[PATCH] D97729: [ARM] Improve WLS lowering

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Thanks, that definitely helped.
LGTM



================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5467
+// A pseudo for a DLSTP, created in the MVETPAndVPTOptimizationPass from a
+// t2DoLoopStart if the loops is tail predicated. Holds a both the element
+// count and trip count of the loop, picking the correct one during
----------------
typo: 'a'


================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5482
+
+// A psuedo to represent the decrement in a low overhead loop. A t2LoopDec and
+// t2LoopEnd together represent a LE instruction. Ideally these are converted
----------------
typo: psuedo


================
Comment at: llvm/lib/Target/ARM/MVETPAndVPTOptimisationsPass.cpp:195
+
+  // Attempt to find a t2WhileLoopStart and revert to a t2Bcc.
+  for (MachineInstr &I : MBB->terminators()) {
----------------
'Attempt' made me wonder if we need to assert if it can't be found, but am not entirely sure now of the value of such an assert.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97729/new/

https://reviews.llvm.org/D97729