[PATCH] D97531: [RuntimeDyld] Speedup resolution of relocations to external symbols

[Rafael Auler via Phabricator via llvm-commits]

rafauler added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp:1140
 
   // Resolution can trigger emission of more symbols, so iterate until
   // we've resolved *everything*.
----------------
That (triggering linking of additional modules) is accomplished here on this loop inside RuntimeDyldImpl::resolveExternalSymbols()

It doesn't look like applyExternalSymbolRelocations() (the previous function) needs to expect that ExternalSymbolMap will be changed while it is iterating over it (see the call in line 1188 happening only after all modules have been loaded).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97531/new/

https://reviews.llvm.org/D97531