[PATCH] D97531: [RuntimeDyld] Speedup resolution of relocations to external symbols
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 10 08:38:14 PST 2021
lhames added a comment.
> After the JITSymbolResolver interface redesign, the functionality has changed, and the loop should no longer trigger repopulation of ExternalSymbolRelocations.
That API change happened a while ago so my recollection may be wrong, but I don't think it changed the fundamental fact that lookup could trigger linking of additional modules. If that's the case I think we could still end up with additional externals needing to be resolved.
Side note: this issue is fixed in ORCv2 / JITLink.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97531/new/
https://reviews.llvm.org/D97531
More information about the llvm-commits
mailing list