[PATCH] D98303: [flang] Update output format test to use GTest
    Asher Mancinelli via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Mar 10 10:04:33 PST 2021
    
    
  
ashermancinelli added a comment.
@klausler I reproduce all of the same test cases, so the test coverage should be identical and should catch all of the same bugs. I'd like to increase coverage, but the patch as-is should keep it the same.
================
Comment at: flang/unittests/RuntimeGTest/NumericalFormatTest.cpp:41-44
+  // This return is ambiguous - did the format fail to be performed, or do the
+  // strings not match?
+  if (status)
+    return false;
----------------
I would be interested in any suggestions for how to better handle this case.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98303/new/
https://reviews.llvm.org/D98303
    
    
More information about the llvm-commits
mailing list