[PATCH] D98303: [flang] Update output format test to use GTest

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 09:34:41 PST 2021


klausler added a comment.

In D98303#2615430 <https://reviews.llvm.org/D98303#2615430>, @ashermancinelli wrote:

> In D98303#2615397 <https://reviews.llvm.org/D98303#2615397>, @klausler wrote:
>
>> Has this version of the tests been validated for its ability to still find bugs in a broken runtime or decimal conversion library?
>
> I apologize for my ignorance here - could you elaborate on this? Do you have a recommendation for how to go about intentionally breaking some component to ensure the tests still catch broken libraries?

The existing version of this test works in the sense that it reliably fails when there's a bug in the Decimal library or in the code in the runtime that processes formatted output.  Will your new version fail when there are bugs in those libraries?  If you're not sure, then please don't replace the test until you are sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98303/new/

https://reviews.llvm.org/D98303



More information about the llvm-commits mailing list