[PATCH] D98221: [AMDGPU] Disable SCC bit on fp atomics

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 15:43:58 PST 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1222-1224
+def isGFX908orGFX90A :
+  Predicate<"Subtarget->hasMAIInsts()">,
+  AssemblerPredicate<(all_of FeatureMAIInsts)>;
----------------
kzhuravl wrote:
> rampitec wrote:
> > kzhuravl wrote:
> > > def hasMAIInsts...? as you are not checking any generation in particular.
> > There is no FeatureGFX90AInsts, we have FeatureMAIInsts instead.
> I think you meant to say that there is no "FeatureGFX908Insts"? FeatureGFX90AInsts exists.
Yes, right.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98221/new/

https://reviews.llvm.org/D98221



More information about the llvm-commits mailing list