[PATCH] D98256: [flang] Save AllocateObject and PointerObject analyzed expression

Jean Perier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 09:58:04 PST 2021


jeanPerier added a comment.

In D98256#2614130 <https://reviews.llvm.org/D98256#2614130>, @PeteSteinfeld wrote:

> 



> Also, when I was working on a bug in check-nullify.cpp, I was initially baffled by the fact that the analysis of the PointerObject's wasn't done in expression analysis rather than in semantic checking.  Do you know what the trade-offs are for analyzing expressions for ALLOCATE, DEALLOCATE, and NULLIFY expressions in semantic analysis rather than expression analysis?

You are raising an interesting point, I do not know. It might make sense to move this in `semantics::ExprChecker`. Let me have a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98256/new/

https://reviews.llvm.org/D98256



More information about the llvm-commits mailing list