[PATCH] D98256: [flang] Save AllocateObject and PointerObject analyzed expression

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 09:45:08 PST 2021


tskeith accepted this revision.
tskeith added inline comments.


================
Comment at: flang/lib/Semantics/check-deallocate.cpp:49
               }
+              return {};
             },
----------------
This case could be simplified slightly:
```
  MaybeExpr checked{analyzer.Analyze(structureComponent)};
  if (checked && ...
  }
  return checked;
```
This reduces the indentation and make the explicit return type unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98256/new/

https://reviews.llvm.org/D98256



More information about the llvm-commits mailing list