[PATCH] D98267: [MemoryDependence] Fix invariant group store

[William Moses via Phabricator via llvm-commits]

wsmoses updated this revision to Diff 329367.
wsmoses added a comment.

Minimize test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98267/new/

https://reviews.llvm.org/D98267

Files:
  llvm/lib/Analysis/MemoryDependenceAnalysis.cpp
  llvm/test/Transforms/GVN/storeinvgroup.ll


Index: llvm/test/Transforms/GVN/storeinvgroup.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/GVN/storeinvgroup.ll
@@ -0,0 +1,21 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -gvn -S -o - < %s | FileCheck %s
+
+define double @code(double* %a1) {
+; CHECK-LABEL: @code(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    [[META:%.*]] = alloca double*, align 8
+; CHECK-NEXT:    store double 1.234500e+00, double* [[A1:%.*]], align 8
+; CHECK-NEXT:    store double* [[A1]], double** [[META]], align 8, !invariant.group !0
+; CHECK-NEXT:    ret double 1.234500e+00
+;
+entry:
+  %meta = alloca double*
+  store double 1.23450000e+00, double* %a1, align 8
+  store double* %a1, double** %meta, align 8, !invariant.group !0
+  %iload = load double, double* %a1, align 8, !invariant.group !1
+  ret double %iload
+}
+
+!0 = distinct !{}
+!1 = distinct !{}
Index: llvm/lib/Analysis/MemoryDependenceAnalysis.cpp
===================================================================
--- llvm/lib/Analysis/MemoryDependenceAnalysis.cpp
+++ llvm/lib/Analysis/MemoryDependenceAnalysis.cpp
@@ -344,7 +344,9 @@
       // If we hit load/store with the same invariant.group metadata (and the
       // same pointer operand) we can assume that value pointed by pointer
       // operand didn't change.
-      if ((isa<LoadInst>(U) || isa<StoreInst>(U)) &&
+      if ((isa<LoadInst>(U) ||
+           (isa<StoreInst>(U) &&
+            cast<StoreInst>(U)->getPointerOperand() == Ptr)) &&
           U->hasMetadata(LLVMContext::MD_invariant_group))
         ClosestDependency = GetClosestDependency(ClosestDependency, U);
     }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98267.329367.patch
Type: text/x-patch
Size: 1703 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210309/7af8b495/attachment.bin>