[PATCH] D98267: [MemoryDependence] Fix invariant group store

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 09:16:18 PST 2021


jdoerfert added a comment.

The test needs to be simplified, remove malloc and print, all geps and bitcasts, metadata, flags, ... everything except the `store %p, %p_ptr` and the `load %p`.

Explain in the commit message what the patch does, sure it fixes an error, but what error, e.g., a store is only invariant to a load if the pointer operands are the same.

Other than that, the logic is sound and fixes the problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98267/new/

https://reviews.llvm.org/D98267



More information about the llvm-commits mailing list