[PATCH] D97726: [sanitizers] [windows] Use InternalMmapVector instead of silencing -Wframe-larger-than

[Russell Gallop via Phabricator via llvm-commits]

russell.gallop added a comment.

In D97726#2613898 <https://reviews.llvm.org/D97726#2613898>, @mstorsjo wrote:

>> These weren't present with the patch.
>
> I presume you meant weren't present without the patch?

That's right, my typo. These weren't present //without// the patch.

> Can you pinpoint which one of the couple changes that is the one that breaks it? There's roughly four cases of buffers converted from plain stack buffer to InternalMmapVector with a bit of syntax changes around each.

It appears to be the change in GetPreferredBase. Reverting just that change causes those ubsan tests to pass.

There are also a lot of failures with check-asan, I think undoing the change in GetPreferredBase fixes those as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97726/new/

https://reviews.llvm.org/D97726