[PATCH] D97726: [sanitizers] [windows] Use InternalMmapVector instead of silencing -Wframe-larger-than

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D97726#2613816 <https://reviews.llvm.org/D97726#2613816>, @russell.gallop wrote:

> In D97726#2612212 <https://reviews.llvm.org/D97726#2612212>, @mstorsjo wrote:
>
>> Can someone with a working windows sanitizers try this one out?
>
> I applied this to cf806d91d562736192f91478eb47daa29c2230bf <https://reviews.llvm.org/rGcf806d91d562736192f91478eb47daa29c2230bf>, built with VS2019 and ran some tests.

Thanks, much appreciated!

> These weren't present with the patch.

I presume you meant weren't present without the patch?

>   Failed Tests (3):
>     UBSan-Standalone-x86_64 :: TestCases/Integer/suppressions.cpp
>     UBSan-Standalone-x86_64 :: TestCases/Misc/missing_return.cpp
>     UBSan-Standalone-x86_64 :: TestCases/TypeCheck/misaligned.cpp

Can you pinpoint which one of the couple changes that is the one that breaks it? There's roughly four cases of buffers converted from plain stack buffer to InternalMmapVector with a bit of syntax changes around each.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97726/new/

https://reviews.llvm.org/D97726