[PATCH] D97480: [RISCV] Support inline asm for vector instructions.

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 09:00:27 PST 2021


HsiangKai added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8087
+  MVT RegVT = *TRI.legalclasstypes_begin(*RC);
+  if (RegVT.getSizeInBits() != RefOpInfo.ConstraintVT.getSizeInBits()) {
+    auto E = TRI.legalclasstypes_end(*RC);
----------------
frasercrmck wrote:
> Does this case trigger for any other target?
> 
> I'm curious: what made you choose this method in the end?
I prefer to use target hooks to solve the issue.
I think I misunderstood you. I will revert it back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97480/new/

https://reviews.llvm.org/D97480



More information about the llvm-commits mailing list