[PATCH] D98236: [RISCV] Add SiFive-VIU75 for llvm

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 07:35:29 PST 2021


jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:281-283
+                                                    FeatureStdExtV,
+                                                    FeatureStdExtZvlsseg,
+                                                    FeatureExtZvamo,
----------------
I don't think we should ever enable V and related extensions here for two reasons:

1. They're currently experimental, so -mcpu=sifive-viu75 bypasses -menable-experimental-extensions.

2. They're still drafts that are going to see changes and we don't maintain backwards compatibility between draft revisions, so as soon as there's a new draft spec we'll have to remove these extensions from this model as the core will no longer implement the spec version we do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98236/new/

https://reviews.llvm.org/D98236



More information about the llvm-commits mailing list