[PATCH] D96931: [LTO] Discard non-prevailing defined symbols in module-level assembly

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 16:00:28 PST 2021


ychen added a comment.

In D96931#2612521 <https://reviews.llvm.org/D96931#2612521>, @pcc wrote:

> This is just solving part of the problem, no? Imagine that you have a weak definition and a global definition in two object files. Then you will have the same problem.

I would think the global one is chosen by the linker?

> I think that some kind of marker that we can use to mark blocks of asm as conceptually coming from different object files would be best.

An array of offsets into the module inlineasm string encoded into metadata?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96931/new/

https://reviews.llvm.org/D96931



More information about the llvm-commits mailing list