[PATCH] D96931: [LTO] Discard non-prevailing defined symbols in module-level assembly

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

This is just solving part of the problem, no? Imagine that you have a weak definition and a global definition in two object files. Then you will have the same problem.

I think that some kind of marker that we can use to mark blocks of asm as conceptually coming from different object files would be best. But as a short term solution it seems best to disable the binding change diagnostic when full LTO is being used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96931/new/

https://reviews.llvm.org/D96931