[PATCH] D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/CodeGen/CGPasses.td:27
+    "fir::FIROpsDialect", "fir::FIRCodeGenDialect", "mlir::BuiltinDialect",
+    "mlir::LLVM::LLVMDialect", "mlir::omp::OpenMPDialect"
+  ];
----------------
mehdi_amini wrote:
> clementval wrote:
> > SouraVX wrote:
> > > I'm not sure whether we need `OpenACC` Dialect too ? (Since OpenACC doesn't lower as `OpenMP`) @clementval do you have any comments/thought on this ?
> > We will probably need it later but since it is not done yet it can be added in a later patch. 
> You only need to list here the dialects that this pass introduces that aren't in the input.
> So basically if you take a `fir` op (or other dialect) and you turn it into an `OpenACC` op then you need to add the dependency (same for the other dialects listed here).
> 
That's what I thought. Since there is no `fir` op to `openacc` op conversion it is not needed. At least for now. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98063/new/

https://reviews.llvm.org/D98063