[PATCH] D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops.
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 8 11:46:54 PST 2021
mehdi_amini added inline comments.
================
Comment at: flang/include/flang/Optimizer/CodeGen/CGPasses.td:27
+ "fir::FIROpsDialect", "fir::FIRCodeGenDialect", "mlir::BuiltinDialect",
+ "mlir::LLVM::LLVMDialect", "mlir::omp::OpenMPDialect"
+ ];
----------------
clementval wrote:
> SouraVX wrote:
> > I'm not sure whether we need `OpenACC` Dialect too ? (Since OpenACC doesn't lower as `OpenMP`) @clementval do you have any comments/thought on this ?
> We will probably need it later but since it is not done yet it can be added in a later patch.
You only need to list here the dialects that this pass introduces that aren't in the input.
So basically if you take a `fir` op (or other dialect) and you turn it into an `OpenACC` op then you need to add the dependency (same for the other dialects listed here).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98063/new/
https://reviews.llvm.org/D98063
More information about the llvm-commits
mailing list