[PATCH] D98174: [MCA] Add tests for IPC on Cortex-A55

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added inline comments.


================
Comment at: llvm/test/tools/llvm-mca/AArch64/Cortex/IPC/A55-0.s:1
+# RUN: llvm-mca -mtriple=aarch64 -mcpu=cortex-a55 --dispatch-stats --iterations=1000 < %s | FileCheck %s
+# CHECK: IPC:
----------------
Do you actually need --dispatch-stats?
If the goal of these tests is to simply check the IPC, then you should be able to simply pass flags `--all-views=false -summary-view`.

I also suggest to pass all these tests through the update_mca python script. If you only enable the summary-view, then the number of checks in the output will be very small.


================
Comment at: llvm/test/tools/llvm-mca/AArch64/Cortex/IPC/A55-4.s:6-7
+# FIXME: DIV is not modeled precisely: on hardware it takes variable
+# number of cycles depending on its operands. LLVM scheduling model
+# only provides an average latency.
+#
----------------
Not sure if it might help in this case, but in general I recommend to have a look at whether some operand constraints might be defined using MCSchedPredicate defs in SchedWriteVariant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98174/new/

https://reviews.llvm.org/D98174