[PATCH] D97403: [flang] updated character tests to gtest

[Asher Mancinelli via Phabricator via llvm-commits]

ashermancinelli marked 2 inline comments as done.
ashermancinelli added a comment.

I've updated the revision - thanks for your comments @awarzynski and @tskeith!



================
Comment at: flang/unittests/RuntimeGTest/CharacterTest.cpp:153
+template <typename CHAR>
+using SCAN_PARAMETER = std::tuple<const CHAR *, const CHAR *, bool, int>;
+
----------------
awarzynski wrote:
> `ScanParameterTy` instead?
I like that 👍 


================
Comment at: flang/unittests/RuntimeGTest/CharacterTest.cpp:221
+template <typename CHAR>
+using VERIFY_PARAMETER = std::tuple<const CHAR *, const CHAR *, bool, int>;
+
----------------
tskeith wrote:
> I suggest: `using VerifyParameter = ...`.
Thanks for the suggestions!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97403/new/

https://reviews.llvm.org/D97403