[PATCH] D98157: [NFC][AMDGPU] Correct typo in DWARF Extensions For Heterogeneous Debugging
Tony Tye via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 7 14:45:47 PST 2021
t-tye created this revision.
t-tye added reviewers: scott.linder, zoran.zaric.
Herald added subscribers: kerbowa, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
t-tye requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.
A note in the defintion of DW_OP_piece had an incomplete sentence.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D98157
Files:
llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst
Index: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst
===================================================================
--- llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst
+++ llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst
@@ -2390,13 +2390,13 @@
.. note::
Since these extensions allow location descriptions to be entries on the
- stack, a simpler operation to create composite location descriptions. For
- example, just one operation that specifies how many parts, and pops pairs
- of stack entries for the part size and location description. Not only
- would this be a simpler operation and avoid the complexities of incomplete
- composite location descriptions, but it may also have a smaller encoding
- in practice. However, the desire for compatibility with DWARF Version 5 is
- likely a stronger consideration.
+ stack, a simpler operation to create composite location descriptions could
+ be defined. For example, just one operation that specifies how many parts,
+ and pops pairs of stack entries for the part size and location
+ description. Not only would this be a simpler operation and avoid the
+ complexities of incomplete composite location descriptions, but it may
+ also have a smaller encoding in practice. However, the desire for
+ compatibility with DWARF Version 5 is likely a stronger consideration.
2. ``DW_OP_bit_piece``
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98157.328907.patch
Type: text/x-patch
Size: 1478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210307/4a0aa5fb/attachment.bin>
More information about the llvm-commits
mailing list