[PATCH] D97403: [flang] updated character tests to gtest

[Asher Mancinelli via Phabricator via llvm-commits]

ashermancinelli added a comment.

@awarzynski

> ALL_CAPS is usually reserved for macros...
> but we should follow the existing precedent in the project...

I'm used to camel case for template args as well and I too searched the documentation for guidance, but not finding a clear policy I tried to follow the conventions in the file being tested:

flang/runtime/character.cpp: <https://github.com/llvm/llvm-project/blob/main/flang/runtime/character.cpp#L111>

  template <typename CHAR, bool ADJUSTR>
  static void Adjust(CHAR *to, const CHAR *from, std::size_t chars) {

Do you think we should break from conventions in the testee? Personally, I too prefer camelcase, but I'll defer to you on this one 🙂


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97403/new/

https://reviews.llvm.org/D97403