[PATCH] D97979: [lld-macho] Check platform and version while constructing ObjFile and DylibFile

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 6 08:32:27 PST 2021


oontvoo marked an inline comment as done.
oontvoo added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:345
+                             const build_version_command *cmd,
+                             const Configuration *config) {
+
----------------
int3 wrote:
> oh I just noticed that you passed in the Configuration as a parameter. It's not necessary since `config` is a global singleton
it was kind of intentional since I didn't like using a global variable in this context .
But now it seemed a lot of other places did that too. Sent a NFC to fix it at   https://reviews.llvm.org/D98115


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97979/new/

https://reviews.llvm.org/D97979



More information about the llvm-commits mailing list