[PATCH] D97979: [lld-macho] Check platform and version while constructing ObjFile and DylibFile

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 19:20:03 PST 2021


int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:345
+                             const build_version_command *cmd,
+                             const Configuration *config) {
+
----------------
oh I just noticed that you passed in the Configuration as a parameter. It's not necessary since `config` is a global singleton


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97979/new/

https://reviews.llvm.org/D97979



More information about the llvm-commits mailing list