[PATCH] D97748: [SystemZ][z/OS] Add support to validate a HLASM Label.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

In D97748#2607182 <https://reviews.llvm.org/D97748#2607182>, @Kai wrote:

> there are some implications with char/string literals inside an inline asm string

Yes, the defined semantics associated with constructs like `CE'^'` were designed to work from a baseline where the HLASM source is in EBCDIC. With XL, inline assembly just doesn't work with `-qASCII` without also having the associated strings "converted" to EBCDIC by user intervention of some sort. So now there's a need to convert only some of the characters from the inline assembly to EBCDIC from UTF-8 at some point (which needs to be one where we know what EBCDIC encoding to convert to). If there's no EBCDIC encoding to convert to (a `-qASCII` case), then an error seems reasonable.

> but this is not part of this change.

Agreed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97748/new/

https://reviews.llvm.org/D97748